Serve API and website behind Caddy path prefixes
Caddy forwards /wizard/api/* and /wizard/website/* with the prefix stripped, so the server received /ws instead of /api/ws and the website connected to /api/ws on the domain root. - Server routes are now /ws and /health (was /api/ws, /api/health) - Website derives the websocket URL from its own location (../api/ws), giving /wizard/api/ws in production and /api/ws in development - Vite dev proxy strips /api like the production proxy - nginx back to the plain SPA config since Caddy strips the prefix - /internal/ai rejects requests that came through the reverse proxy, in addition to the shared secret - Docs updated for the prefixed deployment Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -21,6 +21,6 @@ USER wizard
|
||||
|
||||
EXPOSE 8083
|
||||
HEALTHCHECK --interval=30s --timeout=3s --start-period=5s \
|
||||
CMD python -c "import urllib.request; urllib.request.urlopen('http://127.0.0.1:8083/api/health', timeout=2)"
|
||||
CMD python -c "import urllib.request; urllib.request.urlopen('http://127.0.0.1:8083/health', timeout=2)"
|
||||
|
||||
CMD ["uvicorn", "app.main:app", "--host", "0.0.0.0", "--port", "8083", "--proxy-headers", "--forwarded-allow-ips", "*"]
|
||||
|
||||
@@ -3,7 +3,8 @@
|
||||
FastAPI game server. It manages sessions, lobbies and games, and talks to the AI service.
|
||||
|
||||
- `game_logic/` — the standalone rules engine (`pip install ./game_logic`, see its README).
|
||||
- `app/main.py` — routes: `GET /api/health`, `WS /api/ws` (browsers), `WS /internal/ai` (AI service)
|
||||
- `app/main.py` — routes: `GET /health`, `WS /ws` (browsers), `WS /internal/ai` (AI service,
|
||||
refused when the request came through the reverse proxy)
|
||||
- `app/protocol.py` — client message schema
|
||||
- `app/service.py` — dispatches client messages, reconnects sessions, cleanup
|
||||
- `app/lobby.py` — lobbies, seats, host actions, running games and AI turns
|
||||
|
||||
@@ -1,10 +1,10 @@
|
||||
"""FastAPI application of the Wizard game server.
|
||||
|
||||
Routes:
|
||||
- ``GET /api/health`` health check
|
||||
- ``WS /api/ws`` web clients (see ``app.protocol``)
|
||||
- ``WS /internal/ai`` AI service (see ``app.ai_bridge``); not meant to be
|
||||
exposed by the reverse proxy and protected by ``AI_SHARED_SECRET``
|
||||
Routes (the reverse proxy strips its path prefix, e.g. ``/wizard/api``):
|
||||
- ``GET /health`` health check
|
||||
- ``WS /ws`` web clients (see ``app.protocol``)
|
||||
- ``WS /internal/ai`` AI service (see ``app.ai_bridge``); only accepted from
|
||||
direct connections on the internal network and protected by ``AI_SHARED_SECRET``
|
||||
"""
|
||||
|
||||
from __future__ import annotations
|
||||
@@ -39,7 +39,7 @@ def create_app(config: Settings = settings) -> FastAPI:
|
||||
app = FastAPI(title="Wizard game server", lifespan=lifespan, docs_url=None, redoc_url=None)
|
||||
app.state.service = service
|
||||
|
||||
@app.get("/api/health")
|
||||
@app.get("/health")
|
||||
async def health() -> dict:
|
||||
return {
|
||||
"status": "ok",
|
||||
@@ -48,13 +48,13 @@ def create_app(config: Settings = settings) -> FastAPI:
|
||||
"ai_available": service.bridge.available,
|
||||
}
|
||||
|
||||
@app.websocket("/api/ws")
|
||||
@app.websocket("/ws")
|
||||
async def client_socket(websocket: WebSocket) -> None:
|
||||
await service.handle_client(websocket)
|
||||
|
||||
@app.websocket("/internal/ai")
|
||||
async def ai_socket(websocket: WebSocket) -> None:
|
||||
if not _ai_authorized(websocket, config.ai_shared_secret):
|
||||
if _via_proxy(websocket) or not _ai_authorized(websocket, config.ai_shared_secret):
|
||||
await websocket.close(code=1008)
|
||||
return
|
||||
await service.handle_ai(websocket)
|
||||
@@ -62,6 +62,13 @@ def create_app(config: Settings = settings) -> FastAPI:
|
||||
return app
|
||||
|
||||
|
||||
def _via_proxy(websocket: WebSocket) -> bool:
|
||||
# The reverse proxy forwards everything below its prefix, including
|
||||
# /internal/ai. Requests that went through it carry forwarding headers;
|
||||
# the AI service connects directly over the internal network.
|
||||
return any(name in websocket.headers for name in ("x-forwarded-for", "forwarded", "via"))
|
||||
|
||||
|
||||
def _ai_authorized(websocket: WebSocket, secret: str) -> bool:
|
||||
if not secret:
|
||||
return True
|
||||
|
||||
@@ -1,4 +1,4 @@
|
||||
"""Messages exchanged with web clients over the ``/api/ws`` websocket.
|
||||
"""Messages exchanged with web clients over the ``/ws`` websocket.
|
||||
|
||||
Client -> server messages are validated with pydantic. Server -> client
|
||||
messages are plain dicts:
|
||||
|
||||
@@ -32,7 +32,7 @@ def is_state(message):
|
||||
|
||||
|
||||
def connect(client, token=None):
|
||||
ws = client.sockets.enter_context(client.websocket_connect("/api/ws"))
|
||||
ws = client.sockets.enter_context(client.websocket_connect("/ws"))
|
||||
ws.send_json({"type": "hello", "token": token})
|
||||
welcome = receive_until(ws, lambda m: m["type"] == "welcome")
|
||||
receive_until(ws, is_state)
|
||||
@@ -40,13 +40,13 @@ def connect(client, token=None):
|
||||
|
||||
|
||||
def test_health(client):
|
||||
response = client.get("/api/health")
|
||||
response = client.get("/health")
|
||||
assert response.status_code == 200
|
||||
assert response.json()["status"] == "ok"
|
||||
|
||||
|
||||
def test_requires_hello(client):
|
||||
with client.websocket_connect("/api/ws") as ws:
|
||||
with client.websocket_connect("/ws") as ws:
|
||||
ws.send_json({"type": "create_lobby", "name": "Ann"})
|
||||
assert ws.receive_json()["type"] == "error"
|
||||
|
||||
@@ -118,7 +118,7 @@ def test_reconnect_with_token(client):
|
||||
code = receive_until(ws, is_state)["lobby"]["code"]
|
||||
ws.close()
|
||||
|
||||
ws2 = client.sockets.enter_context(client.websocket_connect("/api/ws"))
|
||||
ws2 = client.sockets.enter_context(client.websocket_connect("/ws"))
|
||||
ws2.send_json({"type": "hello", "token": welcome["token"]})
|
||||
again = receive_until(ws2, lambda m: m["type"] == "welcome")
|
||||
assert again["player_id"] == welcome["player_id"]
|
||||
@@ -153,6 +153,15 @@ def test_ai_endpoint_requires_secret(client):
|
||||
ws.receive_json()
|
||||
|
||||
|
||||
def test_ai_endpoint_rejects_proxied_requests(client):
|
||||
from starlette.websockets import WebSocketDisconnect
|
||||
|
||||
headers = {"Authorization": f"Bearer {SECRET}", "X-Forwarded-For": "203.0.113.7"}
|
||||
with pytest.raises(WebSocketDisconnect):
|
||||
with client.websocket_connect("/internal/ai", headers=headers) as ws:
|
||||
ws.receive_json()
|
||||
|
||||
|
||||
def test_ai_service_decides(client):
|
||||
"""A fake AI service answers decide requests with the first legal action."""
|
||||
requests = []
|
||||
|
||||
Reference in New Issue
Block a user